Open
Conversation
Consistent with project
Reflects better understanding based on ko-vasilev/Hearthstone-Collection-Tracker#24 (comment)
Take a while to run because the file watcher only reads the logs every 5 seconds. If we create a mechanism for adjusting that duration, we could theoretically remove this long timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update configures Hearthstone to start logging the
Achievements.logfile. With an abstracted log file watcher, this update also watches theAchievements.logfile to detect when cards have been gained (signaling a pack has been opened). The update then emits apack-openedevent containing the details of the cards that were obtained.This was discussed a while back (gregstewart/hearthstone-tracker/issues/273) but was abandoned because it was not possible in the logs at the time. Blizzard seems to have since reactivated the relevant logs.